Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path name in HLT BTV valdiation code #9620

Merged
merged 2 commits into from Jun 25, 2015

Conversation

silviodonato
Copy link
Contributor

Replacement of "HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDLoose_" with "HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_",
according to:
https://its.cern.ch/jira/browse/CMSHLT-333

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_5_X.

Fix path name in HLT BTV valdiation code

It involves the following packages:

HLTriggerOffline/Btag

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 18, 2015

please test

@deguio
Copy link
Contributor

deguio commented Jun 18, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Since data taking (and corresponding validation) is actually done with 74X, does it exist (or do you foresee) a 74X counterpart of this pull request?

@silviodonato
Copy link
Contributor Author

Hi Andrea, I've just tried to do it, but I noticed that in 74X we still have the old HLT menu ( http://cmslxr.fnal.gov/source/HLTrigger/Configuration/python/HLT_25ns14e33_v1_cff.py?v=CMSSW_7_4_6 ), it means that we have to keep the old HLT path names:

  • HLT_PFMET120_NoiseCleaned_BTagCSV07_v
  • HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDLoose_

@perrotta
Copy link
Contributor

Ciao Silvio.
This is something that you must agree with DQM gurus. Yes, the HLT menu which is in the release is still the old frozen one, and it will remain as such because of the possible next MC productions. But 74X is also used for the data taking at P5, were the latest HLT menu is going to be deployed. I don't know which is the policy, but I would say that any DQM module in 74X should be able to run with both "old" and "new" path names. Would the new path names be not taken into account by this DQM then they will never be monitored during data taking.

@silviodonato
Copy link
Contributor Author

@danduggan, @deguio can you comment the issue?
In my opinion, unless you've planned to update the HLT menu in 74X, I should keep the old trigger names.
As the validation code is run on RelVal only (and not on data), it is not a problem if we have different trigger names on data. Is it?

@silviodonato
Copy link
Contributor Author

The issue has been solved with #10493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants