Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes on the PF view #9642

Merged
merged 1 commit into from Jun 26, 2015
Merged

Some changes on the PF view #9642

merged 1 commit into from Jun 26, 2015

Conversation

bachtis
Copy link
Contributor

@bachtis bachtis commented Jun 16, 2015

Hi !
I changed some names of the collection and added some objects in the PF detail view.Useful for commissioning.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bachtis (Michalis Bachtis) for CMSSW_7_4_X.

Some changes on the PF view

It involves the following packages:

Fireworks/ParticleFlow

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor

alja commented Jun 16, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

What is the 75x version of this pr?

@bachtis
Copy link
Contributor Author

bachtis commented Jun 19, 2015

Good point. Didnt do one for 75X yet.It should be the same identical commit

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants