Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtx smearing parameters from run 247324 #9646

Conversation

rmanzoni
Copy link
Contributor

back port of
#9645

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_1_X.

Add vtx smearing parameters from run 247324

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #9646 was updated. @cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Jun 16, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cerminar
Copy link
Contributor

@rmanzoni would it be possible to have also a set with the same position as in the 0T data but the other parameters as in NominalCollision2015 ? The idea discussed at the PPD coordination (with @mmusich @diguida @franzoni) is to provide some samples to the POGs to evaluate the possible misplacement of the luminous region without touching the widths.
Thanks,
G

@mmusich
Copy link
Contributor

mmusich commented Jun 23, 2015

@cerminar we already agreed about this. We first need to assess if the Beamspot centroid position is stable enough in the data taken so far. I remind you that the numbers currently proposed just refer to the dN/dEta run

@davidlange6
Copy link
Contributor

@rmanzoni - could you also make this PR consistent with the one that was agreed in 75x.

@rmanzoni
Copy link
Contributor Author

@davidlange6 actually I am a bit confused because, after the discussion that went on for the 75X PR, that PR got merged before I could put the changes in place #9645
In fact this is what I see in the cutting edge 75X
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/Configuration/StandardSequences/python/VtxSmeared.py#L41
Just let me know how to proceed, I'm of course fine with the proposed changes.

@davidlange6
Copy link
Contributor

@rmanzoni - ah - I made a mistake then.. please make the changes agreed with Salvatore there and put both in 75x and 71x..

@cmsbuild
Copy link
Contributor

Pull request #9646 was updated. @cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please check and sign again.

@franzoni
Copy link

Hello,
@rmanzoni
can we please have the two agreed sim beamspot also added to 74? That's where the measurement of the reco beamspot will be carried out
(no need to use 71 gensim for that intermediate step)
Thanks!

@rmanzoni
Copy link
Contributor Author

backport consistent with #9840 (originally #9645)

@rmanzoni
Copy link
Contributor Author

@franzoni yessir! #9841

@franzoni
Copy link

Tks!

davidlange6 added a commit that referenced this pull request Jun 26, 2015
…NdEta_vtx_smearing

Add vtx smearing parameters from run 247324
@davidlange6 davidlange6 merged commit 10a3e15 into cms-sw:CMSSW_7_1_X Jun 26, 2015
@rmanzoni rmanzoni deleted the from-CMSSW_7_1_0_0T_dNdEta_vtx_smearing branch July 15, 2015 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants