New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informative exception for hash collision #9647
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Add informative exception for hash collision It involves the following packages: FWCore/Framework @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. |
29eeec0
to
2dff79f
Compare
Pull request #9647 was updated. @cmsbuild, @Dr15Jones can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add informative exception for hash collision
Fedor Ratnikov ran a reco job that asserted because two different branches had the same 32 bit hash for a branch ID. Unfortunately, we cannot easily fix the hash collision issue, but at least we can issue a clear and informative exception when this occurs, instead of a cryptic assert.