Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix. Add function to get top level PSet #9662

Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Jun 17, 2015

Add a new function that allows one to get a
top level ParameterSet by passing in a
ModuleDescription which is available in
all modules.

This is the Core part of the changes needed to
fix modules that were using the old
getProcessParameterSet function. This depends
on a single global static ParameterSetID.
It fails when used in SubProcesses would return
the ParameterSet for the wrong process/SubProcess.
The bug only affects jobs with SubProcesses.
This global was also problematic for multithreading
(had to be protected with a mutex).

More changes will follow this to convert
all uses of the old function to an alternative
and then eventually to delete it. Merging this
PR quickly will make it easier to test the others
quickly.

Add a new function that allows one to get a
top level ParameterSet by passing in a
ModuleDescription which is available in
all modules.

This is the Core part of the changes needed to
fix modules that were using the old
getProcessParameterSet function. This depends
on a single global static ParameterSetID.
It fails when used in SubProcesses would return
the ParameterSet for the wrong process/SubProcess.
The bug only affects jobs with SubProcesses.
This global was also problematic for multithreading
(had to be protected with a mutex).

More changes will follow this to convert
all uses of the old function to an alternative
and then eventually to delete it. Merging this
PR quickly will make it easier to test the others
quickly.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X.

Bug fix. Add function to get top level PSet

It involves the following packages:

FWCore/Framework
FWCore/Integration
FWCore/ParameterSet

@cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 18, 2015
…roblem

Bug fix. Add function to get top level PSet
@cmsbuild cmsbuild merged commit e469bc2 into cms-sw:CMSSW_7_5_X Jun 18, 2015
@wddgit wddgit deleted the unscheduledSubProcessEventSetupProblem branch September 23, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants