New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix. Add function to get top level PSet #9662
Bug fix. Add function to get top level PSet #9662
Conversation
Add a new function that allows one to get a top level ParameterSet by passing in a ModuleDescription which is available in all modules. This is the Core part of the changes needed to fix modules that were using the old getProcessParameterSet function. This depends on a single global static ParameterSetID. It fails when used in SubProcesses would return the ParameterSet for the wrong process/SubProcess. The bug only affects jobs with SubProcesses. This global was also problematic for multithreading (had to be protected with a mutex). More changes will follow this to convert all uses of the old function to an alternative and then eventually to delete it. Merging this PR quickly will make it easier to test the others quickly.
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X. Bug fix. Add function to get top level PSet It involves the following packages: FWCore/Framework @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. |
Please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…roblem Bug fix. Add function to get top level PSet
Add a new function that allows one to get a
top level ParameterSet by passing in a
ModuleDescription which is available in
all modules.
This is the Core part of the changes needed to
fix modules that were using the old
getProcessParameterSet function. This depends
on a single global static ParameterSetID.
It fails when used in SubProcesses would return
the ParameterSet for the wrong process/SubProcess.
The bug only affects jobs with SubProcesses.
This global was also problematic for multithreading
(had to be protected with a mutex).
More changes will follow this to convert
all uses of the old function to an alternative
and then eventually to delete it. Merging this
PR quickly will make it easier to test the others
quickly.