Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Fix to match Hcal Trig Towers #9669

Merged
merged 1 commit into from Jul 2, 2015

Conversation

vkhristenko
Copy link
Contributor

An inconsistency in the HCAL TrigDetId treatment introduced by
PR #7950/#8103 outside DQM causes mismatch between HCAL TrigTowers from
data and L1 emulator. It will take some time to make a self-consistent
fix.

An urgent quick fix.
ran runTheMatrix.
VK

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_7_4_X.

Temporary Fix to match Hcal Trig Towers

It involves the following packages:

DQM/HcalMonitorTasks

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@abdoulline
Copy link

@deguio, @davidlange6,
please, consider it for the next 745patchX for data processing

@davidlange6
Copy link
Contributor

@abdoulline - is a das failure... as for the PR - is there some more information on this issue reported in hn or a meeting?

@abdoulline
Copy link

Not that I know. There were several private (e-mail) threads and oral discussions at HCAL Operations meetings.
Perhaps Viktor could add a link to elog?

@vkhristenko
Copy link
Contributor Author

@davidlange6 - if you are asking about the reason for PR (what it is aiming
to fix), then a quick mentioning is here
https://indico.cern.ch/event/370943/contribution/1/material/slides/0.pdf on
page 4 "due to failed TP matching"

VK

On Fri, Jun 19, 2015 at 11:44 AM, abdoulline notifications@github.com
wrote:

Not that I know. There were several private (e-mail) threads and oral
discussions at the HCAL Operations meetings.
Probably Viktor could add a link to elog?


Reply to this email directly or view it on GitHub
#9669 (comment).

@abdoulline
Copy link

No elog entries?

(in slide 4 - there was incorrect mentioning of LUTs in the context of the TP mismatch)

On Fri, 19 Jun 2015, Viktor Khristenko wrote:

@davidlange6 - if you are asking about the reason for PR (what it is aiming
to fix), then a quick mentioning is here
https://indico.cern.ch/event/370943/contribution/1/material/slides/0.pdf on
page 4 "due to failed TP matching"

VK

On Fri, Jun 19, 2015 at 11:44 AM, abdoulline notifications@github.com
wrote:

Not that I know. There were several private (e-mail) threads and oral
discussions at the HCAL Operations meetings.
Probably Viktor could add a link to elog?


Reply to this email directly or view it on GitHub
#9669 (comment).


Reply to this email directly or view it on
GitHub.[AEx02ryLiqz7GmZXUEz8y9JojX0JPcfVks5oU_ObgaJpZM4FGPT-.gif]

@deguio
Copy link
Contributor

deguio commented Jun 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants