Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set hierarchy constraints as default in Millepede #9714

Merged
merged 1 commit into from Feb 23, 2016
Merged

Set hierarchy constraints as default in Millepede #9714

merged 1 commit into from Feb 23, 2016

Conversation

mschrode
Copy link

Backport of #9713

@uhh2-bot
Set hierarchy constraints as default.
535c0e8 
Previous problems were found to be due to numerical effects in
pede. These are solved in >=rev137, which uses 'elimination'
instead of lagrangian multipliers.
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jun 21, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_7_4_X.

Set hierarchy constraints as default in Millepede

It involves the following packages:

Alignment/CommonAlignmentAlgorithm

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 535c0e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9714/5598/summary.html

@cmsbuild cmsbuild mentioned this pull request Jun 23, 2015
Closed
@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2016

-1 not for this release cycle anymore

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @diguida
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@mmusich
Copy link
Contributor

mmusich commented Feb 14, 2016

@diguida would you please unhold that one?
as far as I can tell we should have by now MP rev 148 in place for 74X: cms-sw/cmsdist#2108

@diguida
Copy link
Contributor

diguida commented Feb 14, 2016

unhold

@cmsbuild cmsbuild removed the hold label Feb 14, 2016
@mmusich
Copy link
Contributor

mmusich commented Feb 14, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@diguida
Copy link
Contributor

diguida commented Feb 14, 2016

@mmusich thanks for the heads-up.
Indeed, this PR was put on hold as the first Pede revision with the hierarchy constraint fix, namely v140 --> V04-03-00 was included as external only for 76X (cms-sw/cmsdist#1648); 75X PR (cms-sw/cmsdist#1649) was closed at some point, while 74X was not considered at all. Now all 7XY cycles share the latest Pede.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 23, 2016
@cmsbuild
Merge pull request #9714 from mschrode/hierarchyconstraintsasdefault_74X
3b4b252 
Set hierarchy constraints as default in Millepede
@cmsbuild cmsbuild merged commit 3b4b252 into cms-sw:CMSSW_7_4_X Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mschrode @cmsbuild @mmusich @diguida @davidlange6 @uhh2-bot