Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calibration code to properly use TrackerTopology after PR 7966 #9718

Merged
merged 1 commit into from Jun 28, 2015
Merged

Update calibration code to properly use TrackerTopology after PR 7966 #9718

merged 1 commit into from Jun 28, 2015

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jun 22, 2015

Fix a crash due to the recent changes in Tracker paramenters read from DB and TrackerTopology, introduced by PR #7966 , that were not propagated in this calibration code.

@rovere
Fix a crash due to the recent changes in Tracker paramenters read fro…
7c1834f 
…m DB and TrackerTopology, introduced by PR 7966, that were not propagated in this calibration code.
@rovere
Copy link
Contributor Author

rovere commented Jun 22, 2015

@ianna

@ianna
Copy link
Contributor

ianna commented Jun 22, 2015

@cmsbuild - Please, include it in the next IB

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 22, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_5_X.

Update calibration code to properly use TrackerTopology after PR 7966

It involves the following packages:

CalibTracker/Records
CalibTracker/SiStripESProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@jlagram, @gbenelli, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild cmsbuild mentioned this pull request Jun 23, 2015
Merged
@mmusich
Copy link
Contributor

mmusich commented Jun 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7c1834f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9718/5623/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9718/5623/summary.html

davidlange6 added a commit that referenced this pull request Jun 28, 2015
@davidlange6
Merge pull request #9718 from rovere/fix_trackerTopologyInCalibration
67a98e6 
Update calibration code to properly use TrackerTopology after PR 7966
@davidlange6 davidlange6 merged commit 67a98e6 into cms-sw:CMSSW_7_5_X Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rovere @ianna @cmsbuild @mmusich @davidlange6