Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding edm::stream::EDProducer friend for multithread #9720

Merged
merged 1 commit into from Jun 30, 2015

Conversation

amassiro
Copy link
Contributor

Backporting of 75X PR: #9717

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @amassiro (Andrea Massironi) for CMSSW_7_4_X.

adding edm::stream::EDProducer friend for multithread

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented Jun 25, 2015

@cmsbuild tests seem stuck... what should we do?

@mmusich
Copy link
Contributor

mmusich commented Jun 25, 2015

@davidlange6 we need this change to allow introduction of the ElectronStream for the 50ns HLT menu. Can we move forward with the tests?

@ghost
Copy link

ghost commented Jun 25, 2015

@mmusich @davidlange6 I have no idea where the tests sunk, I've restarted them now.

@cmsbuild
Copy link
Contributor

-1
@amassiro This pull request cannot be automatically merged, could you please rebase it?
you can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9720/8354/git-merge-result

@diguida
Copy link
Contributor

diguida commented Jun 26, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1
(indeed, not used offline as @Martin-Grunewald said)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants