New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made static EcalSrFlag::srfNames fully const #9722
Made static EcalSrFlag::srfNames fully const #9722
Conversation
Although it never changed, the static pointer EcalSrFlag::srfNames was non-const. This lead to complaints from the static analyzer.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X. Made static EcalSrFlag::srfNames fully const It involves the following packages: DataFormats/EcalDigi @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
+1 |
Made static EcalSrFlag::srfNames fully const
Although it never changed, the static pointer EcalSrFlag::srfNames
was non-const. This lead to complaints from the static analyzer.