Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the canonical type of std::atomic<T*> in template <T> edm::AtomicPtrC… #9726

Merged
merged 2 commits into from Jun 24, 2015
Merged

the canonical type of std::atomic<T*> in template <T> edm::AtomicPtrC… #9726

merged 2 commits into from Jun 24, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 22, 2015

…ache is atomic<parameter-type-0-0 *>

@gartung
Copy link
Member Author

gartung commented Jun 22, 2015

@Dr15Jones

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 22, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_5_X.

the canonical type of std::atomic<T*> in template edm::AtomicPtrC

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9726/348/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 24, 2015
@cmsbuild
Merge pull request #9726 from gartung/clangSA-add-atomic-tmpl-name
b543765 
the canonical type of std::atomic<T*> in template <T> edm::AtomicPtrC…
@cmsbuild cmsbuild merged commit b543765 into cms-sw:CMSSW_7_5_X Jun 24, 2015
@gartung gartung deleted the clangSA-add-atomic-tmpl-name branch August 27, 2015 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @Dr15Jones @davidlange6