Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal Geometry Packages Dependency Cleanup #9746

Merged
merged 3 commits into from Jun 30, 2015

Conversation

cmsbuild
Copy link
Contributor

  • Moving files to reduce dependencies for Reco part
  • Remove unused code
Geometry/HcalAlgo:
    DetectorDescription/Algorithm
    DetectorDescription/Base
    DetectorDescription/Core
    FWCore/MessageLogger
    FWCore/PluginManager
    tools/Clhepheader

Geometry/HcalCommonData:
    CondFormats/GeometryObjects
    DataFormats/HcalDetId
    DetectorDescription/Base
    DetectorDescription/Core
    FWCore/Framework
    FWCore/MessageLogger
    FWCore/ParameterSet
    Geometry/CaloTopology
    Geometry/Records
    tools/Boost
    tools/Clhepheader

Geometry/HcalEventSetup:
    CondFormats/Alignment
    CondFormats/AlignmentRecord
    DataFormats/HcalDetId
    FWCore/Framework
    FWCore/MessageLogger
    FWCore/ParameterSet
    FWCore/Utilities
    Geometry/CaloEventSetup
    Geometry/CaloGeometry
    Geometry/CaloTopology
    Geometry/HcalTowerAlgo
    Geometry/Records
    tools/Boost

Geometry/HcalSimData:

Geometry/HcalTestBeamData:
    DetectorDescription/Algorithm
    DetectorDescription/Base
    DetectorDescription/Core
    FWCore/MessageLogger
    FWCore/PluginManager
    tools/Clhepheader

Geometry/HcalTowerAlgo:
    CondFormats/AlignmentRecord
    DataFormats/CaloTowers
    DataFormats/Common
    DataFormats/DetId
    DataFormats/GeometryVector
    DataFormats/HcalDetId
    FWCore/Framework
    FWCore/MessageLogger
    FWCore/ParameterSet
    FWCore/PythonParameterSet
    FWCore/Utilities
    Geometry/CaloGeometry
    Geometry/CaloTopology
    Geometry/Records
    tools/Boost
    tools/Roofitcore

Automatically ported from CMSSW_7_5_X #9721 (original by @ianna).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_6_X.

Hcal Geometry Packages Dependency Cleanup

It involves the following packages:

CondTools/Geometry
Geometry/CSCGeometry
Geometry/HcalCommonData
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo
Geometry/MuonNumbering
Geometry/Records

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jun 29, 2015

+1

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants