Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btag DQM: move from binomial error to ClopperPearson error for Efficiency #9864

Merged
merged 3 commits into from Aug 2, 2015

Conversation

acaudron
Copy link

  • Change the way to assign error on Efficiency: binomial -> ClopperPearson as should give better error estimation for low efficiency cases.
  • Take the opportunity to add missing Efficiency Flag for efficiency plots.

Actually the same as #9863.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acaudron for CMSSW_7_5_X.

Btag DQM: move from binomial error to ClopperPearson error for Efficiency

It involves the following packages:

DQMOffline/RecoB

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 2, 2015

please test

@deguio
Copy link
Contributor

deguio commented Jul 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@swertz
Copy link
Contributor

swertz commented Jul 13, 2015

Dear @davidlange6, @Degano, @smuzaffar : what is the status of this PR from your side?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 2, 2015
Btag DQM: move from binomial error to ClopperPearson error for Efficiency
@cmsbuild cmsbuild merged commit 1c1d5c0 into cms-sw:CMSSW_7_5_X Aug 2, 2015
@ferencek ferencek deleted the BtagDQMnewCPerror branch September 4, 2015 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants