New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several usages of un-initialized variables in DQM. #9866
Conversation
In CastorMonitor and DTSegmentsTask the initialization from ParameterSet was commented out, I don't know why. I haven't un-un-commented them, just added initial values. In QcdPhotonsDQM the variable was used to count the number of events, and scale the histogram at the endJob. This should be done via dqm harvesting now what we are multithreaded, and does not make sense in the DQMEDAnalyzer. If someone cares or needs the rates (instead of actual values), we will create a DQMEDHarvester. In L1TdeCSCTF.cc the array was not properly initialized, because of the single-character error left by the developer.
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X. Fix several usages of un-initialized variables in DQM. It involves the following packages: DQM/CastorMonitor @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
Thanks! |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix several usages of un-initialized variables in DQM.
In CastorMonitor and DTSegmentsTask the initialization from
ParameterSet was commented out, I don't know why.
I haven't un-un-commented them, just added initial values.
In QcdPhotonsDQM the variable was used to count the number of events,
and scale the histogram at the endJob.
This should be done via dqm harvesting now what we are multithreaded,
and does not make sense in the DQMEDAnalyzer.
If someone cares or needs the rates (instead of actual
values), we will create a DQMEDHarvester.
In L1TdeCSCTF.cc the array was not properly initialized,
because of the single-character error left by the developer.