New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include d<angle> vs. d<translation> plots in geometry comparison plotter #9879
Include d<angle> vs. d<translation> plots in geometry comparison plotter #9879
Conversation
A new Pull Request was created by @cschomak for CMSSW_7_6_X. Include d vs. d plots in geometry comparison plotter It involves the following packages: Alignment/OfflineValidation @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Include d<angle> vs. d<translation> plots in geometry comparison plotter
Added some plots with dangle on y-axis vs. dtranslation
Added some if clauses to the GeometryComparisonPlotter.cc to handle the case if n_x_variables > n_y_variables which resulted in very squeezed global plots.