fixing memory leak in L1 CSCTrackFinder

[davidlange6]

50MB saved..

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

fixing memory leak in L1 CSCTrackFinder

It involves the following packages:

L1Trigger/CSCTrackFinder

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

This isn't thread safe since it is a global that changes. Shouldn't this just be a member data of this class or put in the EventSetup?

[Dr15Jones]

Also better to use std::unique_ptr< T[]> to manage the memory.

[davidlange6]

even better is to remove the copy altogether and use the conditions object…but less trivial

On Jun 25, 2015, at 3:22 PM, Chris Jones notifications@github.com wrote:

In L1Trigger/CSCTrackFinder/src/CSCTFPtLUT.cc:

@@ -86,16 +86,17 @@ CSCTFPtLUT::CSCTFPtLUT(const edm::EventSetup& es)
//std::cout << "pt_method from 4 " << std::endl;
lowQualityFlag = 4;
isBeamStartConf = true;

- pt_lut = new ptdat[1<<21];

• edm::ESHandle ptLUT;
• es.get().get(ptLUT);

- const L1MuCSCPtLut *myConfigPt_ = ptLUT.product();

- memcpy((void_)pt_lut,(void_)myConfigPt_->lut(),(1<<21)*sizeof(ptdat));

- lut_read_in = true;

• if ( !lut_read_in) {

• pt_lut = new ptdat[1<<21];
  

Also better to use std::unique_ptr< T[]> to manage the memory.

—
Reply to this email directly or view it on GitHub.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: d1b2b1c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9889/5715/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9889/5715/summary.html