Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEMCSCSegAlgoRR: initialize xe and ye #9896

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 25, 2015

DataFormats/GeometryVector/interface/extBasic3DVector.h:78:14: error:
'ye' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
     v{x,y,z,w}{}
          ^
RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegAlgoRR.cc:217:14: note:
'ye' was declared here
    float xe, ye, ze = 0.0;

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

    DataFormats/GeometryVector/interface/extBasic3DVector.h:78:14: error:
    'ye' may be used uninitialized in this function
    [-Werror=maybe-uninitialized]
         v{x,y,z,w}{}
              ^
    RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegAlgoRR.cc:217:14: note:
    'ye' was declared here
        float xe, ye, ze = 0.0;

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

GEMCSCSegAlgoRR: initialize xe and ye

It involves the following packages:

RecoLocalMuon/GEMCSCSegment

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 25, 2015

@cmsbuild please test
(even though the change is fairly trivial)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jun 25, 2015

@davidlt David, which build are you using to get these warnings?

@slava77
Copy link
Contributor

slava77 commented Jun 25, 2015

+1

for #9896 435968d

  • changes are good
  • jenkins compilation is ongoing. The modified code is not in the tested matrix workflows.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlt
Copy link
Contributor Author

davidlt commented Jun 25, 2015

DEVEL on AArch64 with GCC 4.9.2.

davidlange6 added a commit that referenced this pull request Jun 25, 2015
@davidlange6 davidlange6 merged commit 0a27a1f into cms-sw:CMSSW_7_6_X Jun 25, 2015
@cmsbuild
Copy link
Contributor

-1

Tested at: 435968d
I found errors in the following unit tests:

---> test testFWCoreFWLite had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9896/8358/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ea1ef16
cbb4d02
8565f75
82749a0
379b435
ea41bc9
35069af
91328a8
cf7395b
937929f
9cbc784
d3ff862
528377b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9896/8358/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9896/8358/git-merge-result

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants