revert-9344-nohww #9920
Closed
revert-9344-nohww #9920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update reco MET correction producers Conflicts: JetMETCorrections/Type1MET/interface/PFJetMETcorrInputProducerT.h JetMETCorrections/Type1MET/plugins/AddCorrectionsToCaloMET.cc JetMETCorrections/Type1MET/plugins/AddCorrectionsToPFMET.cc
…Type1MET computation
As only some PFCandidates have reference to a Track, mappingTk contains -1 elements. Accessing reverseOrder with -1 gives junk that is then inserted to mappingTk. When these elements are accessed from edm::Association, it will throw "index in the map out of upper boundary" exception, while the expected behaviour would be a null edm::Ref. The fix is to access reverseOrder only if mappingTk[i] is non-negative.
changed to autoCond['run2_design'] added PTrackerParametersRcd from frontier://FrontierProd/CMS_CONDITIONS
…fix + variable for the end condition of for loops instead of function calls
A member data was only set conditionally. This problem was found by valgrind.
…m DB and TrackerTopology, introduced by PR 7966, that were not propagated in this calibration code.
…ueMapProducer-7_5 Fix an uninitialized value in JetDeltaRValueMapProducer
Fix several usages of un-initialized variables in DQM (port to 75x)
updating to use Tracker parameters from DB
fixing memory leak
…ration Update calibration code to properly use TrackerTopology after PR 7966
…ation small changes for performance optimization
Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association
New MET correction/uncertainty tool
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…yComparison Include d<angle> vs. d<translation> plots in geometry comparison plotter
Elestream 75 x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.