Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated HLTTau validation to include legs X in tau+X triggers #9928

Merged
merged 1 commit into from Jul 10, 2015

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Jun 26, 2015

This update adds legs X from tau+X trigger into validation. This is continuing PR #9533, which I could not modify due to missing release top.
The last comment of PR #9533 is now fixed, changed getByLabel -> getByToken. PR #9533 can now be dropped.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slehti for CMSSW_7_6_X.

Updated HLTTau validation to include legs X in tau+X triggers

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Tau

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 8, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

@davidlange6
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Since data taking (and corresponding validation) is actually done with 74X, does it exist (or do you foresee) a 74X counterpart of this pull request?

@slehti
Copy link
Contributor Author

slehti commented Jul 13, 2015

On Mon, 13 Jul 2015, perrotta wrote:

Since data taking (and corresponding validation) is actually done with 74X, does it exist (or do you foresee) a 74X counterpart of this pull request?
Yes. The code compiles and runs also in 74X, and we'd like it to be
included in 74X as well. How do I proceed?

Cheers,
Sami

@perrotta
Copy link
Contributor

Just submit the same pull request to 74X !

@davidlange6
Copy link
Contributor

looks like this is causing problems a number of workflows eg, 1311. Backing out for now.

@mbluj
Copy link
Contributor

mbluj commented Jul 16, 2015

Dear David,
what exact problems is it causing? Do you expect any action from developers of the code (Sami & Co.)?

@deguio
Copy link
Contributor

deguio commented Jul 17, 2015

to reproduce the problems in a 76 release you can do
runTheMatrix.py -l 1311

@slehti
Copy link
Contributor Author

slehti commented Jul 17, 2015

Problem found and fixed. As this PR is closed, do I have to make a new one, or can this be opened again?

@deguio
Copy link
Contributor

deguio commented Jul 20, 2015

ciao @slehti
you can push to the same branch and re-open this PR.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Jul 20, 2015

ok, I see that a new one was submitted. forget my comment then.
F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants