Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jet ordering in MvaMEtUtilities class #9961

Merged
merged 3 commits into from Jul 7, 2015

Conversation

mmarionncern
Copy link

Fix the jet ordering in the mva met utility class, improves slightly the MVA MET performances and makes results consistents

This PR does not impact the standard sequences, no changes expected at all in the tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

Fix jet ordering in MvaMEtUtilities class

It involves the following packages:

RecoMET/METPUSubtraction

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 30, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 2, 2015

+1

For #9961 ae02dcd

Small change to improve sorting of jets for MET MVA. It should not have an effect on standard sequences.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-07-01-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants