New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add standard hadronizers for CP5 tune #1323
Conversation
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Generator.Pythia8CommonSettings_cfi import * | ||
from Configuration.Generator.2017MCTunes.PythiaCP5Settings_cfi import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bendavid these maps https://github.com/cms-sw/cmssw/blob/CMSSW_9_3_0/Configuration/Generator/python/2017MCTunes/PythiaCP5Settings_cfi.py so should be good (unless python doesn't like words starting with a number instead of letter...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed python doesn't like this... there are still ways to import but they are less clean.
PR to fix in 93x and master: cms-sw/cmssw#20571 cms-sw/cmssw#20572
comEnergy = cms.double(13000.), | ||
PythiaParameters = cms.PSet( | ||
pythia8CommonSettingsBlock, | ||
pythia8CP5SettingsBlock, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bendavid on this I am a bit more worried: where was this coming from for CUETP8M1 and so forth?!?
Couldn't find any trace in https://github.com/cms-sw/cmssw/tree/CMSSW_9_3_0/Configuration/Generator/python do you know by heart?
(I mean SettingsBlock)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in cms-sw/cmssw#20571 cms-sw/cmssw#20572
waiting new CMSSW_9_3_X release including cms-sw/cmssw#20571 before to merge |
CMSSW_9_3_1 is out https://github.com/cms-sw/cmssw/releases/CMSSW_9_3_1 |
cloned existing TuneCUEP8M1 existing files using the command
done
and replacing CUEP8M1 by CP5