Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard hadronizers for CP5 tune #1323

Merged
merged 2 commits into from Sep 20, 2017
Merged

Conversation

perrozzi
Copy link
Contributor

@perrozzi perrozzi commented Sep 18, 2017

cloned existing TuneCUEP8M1 existing files using the command

for f in python/ThirteenTeV/Hadronizer/*.py; do cp "$f" "echo $f | sed s/TuneCUETP8M1/TuneCP5/";

done

and replacing CUEP8M1 by CP5

import FWCore.ParameterSet.Config as cms

from Configuration.Generator.Pythia8CommonSettings_cfi import *
from Configuration.Generator.2017MCTunes.PythiaCP5Settings_cfi import *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bendavid these maps https://github.com/cms-sw/cmssw/blob/CMSSW_9_3_0/Configuration/Generator/python/2017MCTunes/PythiaCP5Settings_cfi.py so should be good (unless python doesn't like words starting with a number instead of letter...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed python doesn't like this... there are still ways to import but they are less clean.
PR to fix in 93x and master: cms-sw/cmssw#20571 cms-sw/cmssw#20572

comEnergy = cms.double(13000.),
PythiaParameters = cms.PSet(
pythia8CommonSettingsBlock,
pythia8CP5SettingsBlock,
Copy link
Contributor Author

@perrozzi perrozzi Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bendavid on this I am a bit more worried: where was this coming from for CUETP8M1 and so forth?!?
Couldn't find any trace in https://github.com/cms-sw/cmssw/tree/CMSSW_9_3_0/Configuration/Generator/python do you know by heart?
(I mean SettingsBlock)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrozzi
Copy link
Contributor Author

waiting new CMSSW_9_3_X release including cms-sw/cmssw#20571 before to merge

@perrozzi perrozzi merged commit e63510e into cms-sw:master Sep 20, 2017
@perrozzi
Copy link
Contributor Author

CMSSW_9_3_1 is out https://github.com/cms-sw/cmssw/releases/CMSSW_9_3_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant