Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Complain about invalid sources again #169

Closed
wants to merge 1 commit into from
Closed

[WIP] Complain about invalid sources again #169

wants to merge 1 commit into from

Conversation

smuzaffar
Copy link

This used to be a local ROOT patch of Clang
(vgvassilev/clang@a5ee33ae48)
However, after trying to upstream it, there're two tests broken:

  • Modules/module-file-modified.c
  • Modules/explicit-build-missing-files.cpp

I have talked with Vassil briefly and he said this change has something
to do with virtual files. Let's try to revert this and see how ROOT's
tests break. Ideally we'll find a more appropriate approach.

This used to be a local ROOT patch of Clang
(vgvassilev/clang@a5ee33ae48)
However, after trying to upstream it, there're two tests broken:

* Modules/module-file-modified.c
* Modules/explicit-build-missing-files.cpp

I have talked with Vassil briefly and he said this change has something
to do with virtual files. Let's try to revert this and see how ROOT's
tests break. Ideally we'll find a more appropriate approach.
@smuzaffar
Copy link
Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/9114cac.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Author

please test for CMSSW_12_5_ROOT6_X

@cmsbuild
Copy link

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f558/24951/summary.html
COMMIT: 30d6a12
CMSSW: CMSSW_12_5_ROOT6_X_2022-05-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/169/24951/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f558/24951/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f558/24951/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17485 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3650985
  • DQMHistoTests: Total failures: 40205
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3610758
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.465 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -1.465 KiB SiStrip/MechanicalView
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 6 / 49 workflows

@smuzaffar smuzaffar closed this Jun 10, 2022
@junaire junaire deleted the dont-complain-wip branch June 27, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants