Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROOT's llvm to llvm13 #177

Closed
wants to merge 154 commits into from

Conversation

smuzaffar
Copy link

No description provided.

@smuzaffar
Copy link
Author

please test with cms-sw/cmsdist#8192

@cmsbuild
Copy link

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/323c21416c.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57f21d/29184/summary.html
COMMIT: 22dd7f8
CMSSW: CMSSW_12_6_ROOT6_X_2022-11-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/177/29184/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
* The action "build-external+py3-hepdata-lib+0.10.1-d5a65a50fc66bb6ceb2097b9bc30c480" was not completed successfully because Failed to build py3-hepdata-lib. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.10.1-d5a65a50fc66bb6ceb2097b9bc30c480/log. Final lines of the log file:
'"'"''"'"''"'"' % ('"'"'/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.10.1-d5a65a50fc66bb6ceb2097b9bc30c480/cmsdist-tmp/pip-req-build-xawrhk43/setup.py'"'"',), "", "exec"))' egg_info --egg-base /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.10.1-d5a65a50fc66bb6ceb2097b9bc30c480/cmsdist-tmp/pip-pip-egg-info-gs0d5ue1
cwd: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.10.1-d5a65a50fc66bb6ceb2097b9bc30c480/cmsdist-tmp/pip-req-build-xawrhk43/
Preparing metadata (setup.py): finished with status 'error'
error: metadata-generation-failed

 Encountered error while generating package metadata.
> See above for output.

note: This is an issue with the package mentioned above, not pip.


@cmsbuild
Copy link

Pull request #177 was updated.

5 similar comments
@cmsbuild
Copy link

Pull request #177 was updated.

@cmsbuild
Copy link

Pull request #177 was updated.

@cmsbuild
Copy link

Pull request #177 was updated.

@cmsbuild
Copy link

Pull request #177 was updated.

@cmsbuild
Copy link

Pull request #177 was updated.

@smuzaffar
Copy link
Author

please test with cms-sw/cmsdist#8192

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57f21d/29249/summary.html
COMMIT: 6e9cad5
CMSSW: CMSSW_13_0_ROOT6_X_2022-11-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/177/29249/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57f21d/29249/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57f21d/29249/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8765 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417239
  • DQMHistoTests: Total failures: 40958
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3376258
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.43 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 1.430 KiB SiStrip/MechanicalView
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@smuzaffar
Copy link
Author

please test

Axel-Naumann and others added 17 commits December 9, 2022 07:31
Previously, one needed to pass linker-mangled names, which exposes details that
clients of IncrementalExecutor should not have to deal with. Instead, use the IR
name and do the linker-mangling in IncrementalJIT::addOrReplaceDefinition().

This fixes the lack of static destruction on macOS, visible e.g. in the test
failure of roottest/cling/staticinit/ROOT-7775.
This helps with debugging why a certain header does not end up in a
module that is currently generated.
It is used by core/base and causes laying violations with modules, see
module ROOT_Foundation_C which needs to contain ThreadLocalStorage.h.
This is still required for proper exception handling support. See
commits 3f74182 and a7b0b3e by Philippe for details on the
problem and the original code, which I was able to significantly
simplify with the new JIT infrastructure.

For the moment, this disables JITLink even on platforms that had it
active by default (notably macOS). This will be reintroduced at a
later point, which will require a memory manager implementation for
the JITLink interface.
This is required until CallFunc is informed about unloading, and can
re-generate the wrapper (if the decl is still available).
If the Decl pointers are not identical, declaresSameEntity will check
the canonical Decls. This fixes the df021_createTGraph tutorial on
CentOS 8.

Upstream discussion in https://reviews.llvm.org/D137787
It finds a false positive in llvm::DataLayout::reset accessing
DefaultAlignments while loading the Net library. At this point,
Cling and LLVM have definitely been initialized. This is a known
limitation of the order check, which is why it was disabled by
default. Remove our config to enable it for now to allow checking
the LLVM upgrade with AddressSanitizer instrumentation.
This is only used to determine the architecture for OpenMP offloading,
which we are not interested in.
As https://johannst.github.io/notes/development/symbolver.html points out,
"@@" just means "default version". We want to skip any versioned GCC/glibc/
libstdc++ symbol. Significantly reduces appetite for searching symbols.

Then also skip wek symbols: even if they are unresolved we will happily
not have them if they have not been loaded so far. Typical case is
`__gmon_start__`.
When creating orec-Symbols for dylib symbols, reloading the
dylib might mean a change in symbol (address). So unloading a
dylib means we need to unload the orc-Symbol.

This is implemented through resource-tracking the symbols as
provided by DynamicLibrarySearchGenerator. Actually, as
DynamicLibrarySearchGenerator does not support resource tracking,
it is implemented in a near-copy of DynamicLibrarySearchGenerator,
RTDynamicLibrarySearchGenerator, which uses the transaction of the
most recent module for the ResourceTracker.
The splitting code requires the full string to be null-terminated.
Before, random bytes were attached to the last option.
on macOS11, stressInterpreter fails with not re-emitting _ZL6strstrUa9enable_ifILb1EEPKcS0_.
It has internal linkage: originally deferred, it needs a chance to be re-emitted.
Simplify this to include anything that was deferred and is either weak-for-linker or
internal, to hopefully match all cases.
@cmsbuild
Copy link

cmsbuild commented Dec 9, 2022

Pull request #177 was updated.

@smuzaffar smuzaffar changed the base branch from cms/master/bfe11796ea to cms/master/6041136 December 9, 2022 07:38
@smuzaffar
Copy link
Author

please test with cms-sw/cmsdist#8223

@smuzaffar
Copy link
Author

please test with cms-sw/cmsdist#8223

using newer IB

@smuzaffar
Copy link
Author

abort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants