Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module Configuration code #1

Open
wants to merge 3,396 commits into
base: master
Choose a base branch
from
Open

Module Configuration code #1

wants to merge 3,396 commits into from

Conversation

libelle
Copy link

@libelle libelle commented Sep 3, 2010

Included is my module configuration code. Currently, the approach is to load the module's method.configure.php from ModuleManager's action.configure.php (via class.cms_module_operations.php).

There's some confusion with the module trying to call a method via ModuleManager's action. I need a slightly bigger brain to actually make it work.

I think the infrastructural code (CmsModulePreferenceExtension, changes to module loader) is sound, even if the configuration process part of the mechanism requires rethinking.

calguy1000 and others added 30 commits August 29, 2009 21:22
Fixes minor issue with register routes.
82135cb 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5937 3d254a34-79dc-0310-9e5f-be208747d8a0
Remove calls to removed callback function.
8f3b552 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5938 3d254a34-79dc-0310-9e5f-be208747d8a0
Remove the cms reference in the module.
76aacf0 
Remove the config reference in the module
Make most members private, 


git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5939 3d254a34-79dc-0310-9e5f-be208747d8a0
Don't use $this->smarty any more.
30e32da 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5940 3d254a34-79dc-0310-9e5f-be208747d8a0
Fixes use of $this->config which no longer exists in the module object.
e553b15 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5941 3d254a34-79dc-0310-9e5f-be208747d8a0
Remove references to $this->cms
4d68058 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5942 3d254a34-79dc-0310-9e5f-be208747d8a0
Adds the new set_language plugin, using this variable will override a…
ea28f46 
…ny lang= parameters used in subsequent module calls.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5943 3d254a34-79dc-0310-9e5f-be208747d8a0
Adds the CmsNls class, rewrites the nls.php files to be more namespac…
af1844a 
…e specific, and adds the {set_language_auto} plugin.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5944 3d254a34-79dc-0310-9e5f-be208747d8a0
Adds the sticky=1 parameter.
57a0ed3 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5945 3d254a34-79dc-0310-9e5f-be208747d8a0
Splits the session stuff in set_language_auto into to params.... stic…
5c4413a 
…ky=1 to save the detected language, and use_sticky=1 to use a previously detected language if it exists, but not set one.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5946 3d254a34-79dc-0310-9e5f-be208747d8a0
Fix class name issue.
8016942 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5949 3d254a34-79dc-0310-9e5f-be208747d8a0
Adds the module object to smarty at the top of the DoAction call.
5b5ace4 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5950 3d254a34-79dc-0310-9e5f-be208747d8a0
Fix dumb error on my part.
9dcb42f 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5951 3d254a34-79dc-0310-9e5f-be208747d8a0
Fixes to listmodules (put the xml stuff back in)
75fc2f0 
Fixes list of system modules.
Minor fix to the nb_NO.nls file


git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5952 3d254a34-79dc-0310-9e5f-be208747d8a0
fixed a warning in imagefiles related to the ageold htmlarea-stuff
88f8192 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5953 3d254a34-79dc-0310-9e5f-be208747d8a0
Fix attempt to access private member.
26f6906 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5954 3d254a34-79dc-0310-9e5f-be208747d8a0
Rix another problem with access to private member variable... I bet t…
c7c90e7 
…here's gonna be a few of these.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5955 3d254a34-79dc-0310-9e5f-be208747d8a0
And yet another one.
fd07d6a 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5956 3d254a34-79dc-0310-9e5f-be208747d8a0
More fixes for private members... adds a protected member for mOldAlias
0642c3e 
gawd it's nice having php 5


git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5957 3d254a34-79dc-0310-9e5f-be208747d8a0
Fixes add content message.
eb76bca 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5958 3d254a34-79dc-0310-9e5f-be208747d8a0
Applies changes from 1.6.5
56db3f0 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5967 3d254a34-79dc-0310-9e5f-be208747d8a0
Applies MenuManager changes from 1.6.5
eadc255 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5968 3d254a34-79dc-0310-9e5f-be208747d8a0
Fix minor error.
87fb874 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5969 3d254a34-79dc-0310-9e5f-be208747d8a0
Many many changes
4386627 
Fixed some php 5.3 issues
Added nested set logic to content tree
Slowly making everything lazy loaded


git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5970 3d254a34-79dc-0310-9e5f-be208747d8a0
Some fixes for content problems.... still more work to be done.
1320aaf 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5971 3d254a34-79dc-0310-9e5f-be208747d8a0
Adds showtemplate=false support to module actions in the admin, for c…
b7c3e5f 
…ompatibility purposes.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5972 3d254a34-79dc-0310-9e5f-be208747d8a0
Adds CreateURL method.
76db476 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5973 3d254a34-79dc-0310-9e5f-be208747d8a0
Fixes menumanager for new content stuff in 1.7
3b04c6f 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5974 3d254a34-79dc-0310-9e5f-be208747d8a0
Fix stupidity in CreateURL method.
883a51c 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5975 3d254a34-79dc-0310-9e5f-be208747d8a0
Pulled content base changes from 2.0 branch
4b0d5b2 
Reorganized listcontent so that it works with the changes


git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/branches/1.7.x@5976 3d254a34-79dc-0310-9e5f-be208747d8a0
wishy and others added 21 commits July 14, 2010 03:30
Merge branch 'smarty3'
71680e0 
Conflicts:
	plugins/function.root_url.php

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6503 3d254a34-79dc-0310-9e5f-be208747d8a0
Redid the content block parsing to use the lexer instead of
bc3ec63 
processing it with a render. Now unsucceptable to template logic.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6505 3d254a34-79dc-0310-9e5f-be208747d8a0
Comment up the content block parser hack. Put in handling for quotes
685fd00 
around returned values.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6514 3d254a34-79dc-0310-9e5f-be208747d8a0
Added tests for the content block parsing
b0b9891 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6515 3d254a34-79dc-0310-9e5f-be208747d8a0
Added content_types table
386ce63 
Removed all the upgrade scripts and reverted back to db version 1

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6516 3d254a34-79dc-0310-9e5f-be208747d8a0
First pass as database based content types. Module based types
382294f 
are not implemented yet, as well as any other type other than
"HTML Content".

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6517 3d254a34-79dc-0310-9e5f-be208747d8a0
More content type work. Added default
6c94eb1 
html_content type to the default install.
Removed the content table relying on 'type' 
so modules can handle content types however they 
want.

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6518 3d254a34-79dc-0310-9e5f-be208747d8a0
Removed some warnings on install, removed unused config option
adecf05 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6521 3d254a34-79dc-0310-9e5f-be208747d8a0
Make sure certain module parameters are always allowed
bcf7abb 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6522 3d254a34-79dc-0310-9e5f-be208747d8a0
Updated cms_stylesheet. Since we are using Smarty 3 we can use { and …
f355ed6 
…} in the stylesheets

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6523 3d254a34-79dc-0310-9e5f-be208747d8a0
Added CmsModuleLoader::has_capability
a6c80fb 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6529 3d254a34-79dc-0310-9e5f-be208747d8a0
Commented out news tags in default templates for now
72fdce1 
Change memcache key cache to use a persistent connection

git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6530 3d254a34-79dc-0310-9e5f-be208747d8a0
Bumped smarty to 3.0rc3
d19c598 
git-svn-id: http://svn.cmsmadesimple.org/svn/cmsmadesimple/trunk@6531 3d254a34-79dc-0310-9e5f-be208747d8a0
First pass at page types. Editing content now needs
566cd8f 
a big refactor in order to have all fields controlled
by the page type.  Also, you'll have to reinstall
after this commit.
Fix for page_type field name
4d68f23
Page Types
9b4d089 
Error code checking in CmsResponse
Cleanup some unused files and templates
Added wysiwyg and syntax highlighter interfaces
c2f5ff3 
Documented wysiwyg and syntax_highlighter "core" capabilities
Changed textarea generation code to make use of CmsModuleLoader changes
Add MicroTiny as a core module, update for 2.0 style
Got MicroTiny displaying in it's basic form. Still need work to submit forms, though.
Fix long standing bug with date handling of automated fields in the ORM
3c8cc37
Fix more fixes for 2.0edness in MicroTiny
adca840 
De-bump version to 2.0-alpha1
Changing page type reloads the summary panel via delicious ajax
53f985c
Initial attempt at module configuration ... not yet successful
f0502a4
@tedkulp
Copy link
Member

tedkulp commented Sep 3, 2010

Cool. I'll look it over tomorrow and see if I can help you track it down.

@tedkulp
Copy link
Member

tedkulp commented Sep 3, 2010

Ok, I have a few questions/suggestions on the code, when you get in this morning.

@tedkulp
Copy link
Member

tedkulp commented Oct 6, 2010

Think I should pull this in? I know we still need to make some changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@libelle @tedkulp @tchalvak @ajprog