Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Mount socket path in duffle.json #894

Open
maingoh opened this issue Mar 18, 2020 · 2 comments
Open

Mount socket path in duffle.json #894

maingoh opened this issue Mar 18, 2020 · 2 comments

Comments

@maingoh
Copy link

maingoh commented Mar 18, 2020

I would like to use duffle with docker compose (I cannot use docker app because of its restriction to docker compose 3 format). Thus I need to mount the docker socket like here https://github.com/docker/app/blob/dc6d86d1163f63ade2a2d6a585e9559fec4b3f1c/internal/cnab/driver.go#L99
However I would like to avoid creating a custom driver. Is it possible to mount it in the invocationImages field of the duffle.json ? I cannot find documentation about the dockerConfigurationOptions here https://github.com/cnabio/cnab-go/blob/03423407b46b8c61ba8c82588c6cd9a61fc213ed/driver/docker/docker.go#L31

@maingoh
Copy link
Author

maingoh commented Mar 18, 2020

Alternatively can I build a custom driver by reusing the docker driver and mounting volume during install ?

@vdice
Copy link
Member

vdice commented Mar 18, 2020

Coincidentally, this functionality is currently in PR form in Porter (another CNAB runtime) to do similar. Note the implementation in https://github.com/deislabs/porter/pull/951/files#diff-7816965629edfe825f9dc9a1737826c5R58-R78 . This should guide you on how to add support in Duffle.

The Porter maintainers are still discussing what the desired state will be regarding how to enable this functionality. I don't recall having the same discussion here in the Duffle reference implementation repo.

@radu-matei has mentioned going the custom driver route (if I recall correctly). We could also feasibly go the required custom extensions route as well (acting as a toggle to turn on the added functionality in Duffle).

Perhaps while this discussion proceeds, you have enough to go on to add support in a branch for testing and seeing how it works for your needs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants