This repository has been archived by the owner on May 3, 2022. It is now read-only.
update bundle remove flag/help #697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
carolynvs
reviewed
Apr 8, 2019
| @@ -16,7 +16,7 @@ import ( | |||
| const bundleRemoveDesc = `Remove a bundle from the local storage. | |||
|
|
|||
| This removes a bundle from the local storage so that it will no longer be locally | |||
| available. Bundles can be rebuilt with 'duffle build'. | |||
| available. Bundles can be rebuilt and store in local storage with 'duffle build'. | |||
There was a problem hiding this comment.
nit: and stored in local storage
| @@ -46,7 +46,7 @@ func newBundleRemoveCmd(w io.Writer) *cobra.Command { | |||
| return remove.run() | |||
| }, | |||
| } | |||
| cmd.Flags().StringVar(&remove.versions, "version", "", "A version or SemVer2 version range") | |||
| cmd.Flags().StringVarP(&remove.versions, "version", "r", "", "A version or SemVer2 version range") | |||
There was a problem hiding this comment.
So the command should be duffle bundle rm mybundle -r version why -r as the shortcut for version?
There was a problem hiding this comment.
I suppose because -v is used for verbose output (at least it's supposed to be used that way, Simon pointed out that it's currently not working as intended).
There was a problem hiding this comment.
I guess the alternative would be not to have a shorthand flag at all?
(I'm happy with this approach, as -r is not really intuitive for passing a version).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #692