Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon support, update dependencies #63

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wdhg
Copy link

@wdhg wdhg commented Sep 27, 2021

No description provided.

@@ -109,7 +114,7 @@ export async function activate(context: ExtensionContext) {
}
await omnisharpProvider.downloadLanguageServer()
if (useCustomPath) {
workspace.showMessage(`coc-omnisharp: Using custom executable (${omnisharpCustomPath}) so the downloaded bundle will have no effect`, 'warning')
window.showMessage(`coc-omnisharp: Using custom executable (${omnisharpCustomPath}) so the downloaded bundle will have no effect`, 'warning')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this "window dot" thing will show that little popup window?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe so yes, check out this commit

const omnisharpPacks: ILanguageServerPackages = {
"win-x64": { platformPath: "omnisharp-win-x64.zip", executable: "Omnisharp.exe" },
"linux-x64": { platformPath: "omnisharp-linux-x64.zip", executable: "run" },
"osx-x64": { platformPath: "omnisharp-osx.zip", executable: "run" },
"osx-arm64": { platformPath: "omnisharp-osx.zip", executable: "run" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a universal package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it runs on my M1 MacBook so i believe it is

"@types/node": "^10.3.3",
"typescript": "^3.5.2",
"coc.nvim": "^0.0.73"
"@types/node": "^16.9.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep node version to 12?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can try and downgrade it but may i ask why?

@yatli
Copy link
Member

yatli commented Sep 27, 2021

thanks for the updates!

@ins429
Copy link

ins429 commented Feb 2, 2022

Any updates on this PR? Would love to see this merged!

@kaicataldo
Copy link

Anything any of us can do to help land this? I'm working on a .NET project right now and would love to have this working.

@wdhg
Copy link
Author

wdhg commented Mar 22, 2022

Anything any of us can do to help land this? I'm working on a .NET project right now and would love to have this working.

I don't have time atm to try and test downgrading the node version back to 12. In the meantime (until this gets merged), you can just use my fork instead. For example:

Plug 'wdhg/coc-omnisharp'

@kaicataldo
Copy link

Would you be amenable to someone else doing that testing? I'm happy to give it a look!

@wdhg
Copy link
Author

wdhg commented Mar 24, 2022

Sure! If you make a PR into my fork I'll merge it or if you PR into this repo then I can close this PR.

@aaronzper
Copy link

Anything any of us can do to help land this? I'm working on a .NET project right now and would love to have this working.

I don't have time atm to try and test downgrading the node version back to 12. In the meantime (until this gets merged), you can just use my fork instead. For example:

Plug 'wdhg/coc-omnisharp'

How do I actually install the fork? Installing the plug like that through my vim config didn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants