Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded API11 for the openharmony platform #16962

Merged
merged 6 commits into from May 24, 2024

Conversation

qiuguohua
Copy link
Contributor

#16905

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@qiuguohua qiuguohua requested a review from minggo May 10, 2024 01:18
Copy link

github-actions bot commented May 10, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -19519,9 +19519,9 @@
         export class frustum extends Frustum {
             constructor();
         }
     }
-    export const VERSION = "3.8.3";
+    export const VERSION = "3.8.4";
     /**
      * @en
      * The main namespace of Cocos engine, all engine core classes, functions, properties and constants are defined in this namespace.
      * @zh

// return ps.join(this.params.platformParams.sdkPath, 'toolchains/hdc');
// }
// return null;
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove codes if they are not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed in the future, it's just that the current SDK path changes frequently, so it's commented out for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@qiuguohua qiuguohua closed this May 20, 2024
@qiuguohua qiuguohua reopened this May 20, 2024
Copy link

@qiuguohua ❗ There was an error during the execution of the tasks. Please check the logs for more details.

@minggo minggo merged commit 86c0caf into cocos:v3.8.4 May 24, 2024
20 of 21 checks passed
Copy link

@qiuguohua ❗ There was an error during the execution of the tasks. Please check the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants