Lab2: add source validator for labs with JSON sources #58445
Conversation
sanchitmalhotra126
requested review from
bencodeorg,
molly-moen,
fisher-alice and
a team
| try { | ||
| JSON.parse(responseToValidate.source as string); | ||
| } catch (e) { | ||
| throw new ValidationError('Error parsing JSON: ' + e); |
There was a problem hiding this comment.
Looks like you're following the existing pattern, but for my understanding, where does this get caught? I can't seem to trace it properly 🤦
There was a problem hiding this comment.
No worries this code is a bit tricky to follow 🙂 this ValidationError is eventually caught by ProjectManager when it attempts to load sources for the project:
code-dot-org/apps/src/lab2/projects/ProjectManager.ts
Lines 88 to 91 in 7b86d9c
It takes care of defaulting to empty sources and thereby not passing the invalid sources to labs.
There was a problem hiding this comment.
Thanks for the explanation. Where are sources assigned {}?
There was a problem hiding this comment.
Oh, they're just never assigned (they stay undefined from
| @@ -46,6 +46,21 @@ const PythonSourceResponseValidator: ResponseValidator< | |||
| return sourceValidatorHelper(response, pythonValidator); | |||
| }; | |||
|
|
|||
| // Validator for labs that use JSON sources | |||
| const JsonSourceResponseValidator: ResponseValidator< | |||
There was a problem hiding this comment.
nit: technically, Blocky sources are also json sources I think.
There was a problem hiding this comment.
Good call, will update the comment to specify
| try { | ||
| JSON.parse(responseToValidate.source as string); | ||
| } catch (e) { | ||
| throw new ValidationError('Error parsing JSON: ' + e); |
There was a problem hiding this comment.
Thanks for the explanation. Where are sources assigned {}?
Quick convenience fix; in local development, we're running into a lot of AI Chat levels that share channel IDs with old labs that have incompatible sources, and have to manually go into S3 to delete the old sources. For other labs (Blockly/Python lab), the response validators will let us fall back to empty sources, so this adds similar behavior for AI Chat and any other labs that use JSON sources; if the JSON cannot be parsed, we'll fall back to empty sources.
Testing story
Tested with AI chat levels in the gen-ai-foundations-draft script.