Skip to content

Commit

Permalink
#5107: Fix a crash related to project setup changes, due to concurren…
Browse files Browse the repository at this point in the history
…t calls of SceneGraph::boundsChanged by both the eclass def loader and the material manager realisation thread.

This commit doesn't make it thread-safe, but the call to SceneGraph::boundsChanged is actually unnecessary when just the face shader has been changed.
  • Loading branch information
codereader committed Nov 19, 2020
1 parent ac0ed1f commit 01dbfae
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion radiantcore/brush/Brush.cpp
Expand Up @@ -480,7 +480,8 @@ void Brush::onFacePlaneChanged()

void Brush::onFaceShaderChanged()
{
onFacePlaneChanged();
// When the face shader changes, no geometry change is happening
// therefore no call to onFacePlaneChanged() is necessary

// Queue an UI update of the texture tools if any of them is listening
signal_faceShaderChanged().emit();
Expand Down

0 comments on commit 01dbfae

Please sign in to comment.