Skip to content

Commit

Permalink
#5622: Rename map::algorithm::mergeMap to map::algorithm::importMap t…
Browse files Browse the repository at this point in the history
…o not collide with the upcoming changes
  • Loading branch information
codereader committed May 22, 2021
1 parent 2303d33 commit 1a5db5d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions radiantcore/map/Map.cpp
Expand Up @@ -426,7 +426,7 @@ bool Map::import(const std::string& filename)
// Adjust all new names to fit into the existing map namespace
algorithm::prepareNamesForImport(getRoot(), otherRoot);

algorithm::mergeMap(otherRoot);
algorithm::importMap(otherRoot);
success = true;
}

Expand Down Expand Up @@ -944,7 +944,6 @@ void Map::mergeMap(const cmd::ArgumentList& args)
throw cmd::ExecutionFailure(fmt::format(_("File doesn't exist: {0}"), candidate));
}


}

void Map::emitMapEvent(MapEvent ev)
Expand Down
4 changes: 2 additions & 2 deletions radiantcore/map/algorithm/Import.cpp
Expand Up @@ -227,7 +227,7 @@ class EntityMerger :
}
};

void mergeMap(const scene::INodePtr& node)
void importMap(const scene::INodePtr& node)
{
if (!GlobalSceneGraph().root())
{
Expand Down Expand Up @@ -360,7 +360,7 @@ void importFromStream(std::istream& stream)
// Adjust all new names to fit into the existing map namespace
prepareNamesForImport(GlobalMap().getRoot(), importFilter.getRootNode());

mergeMap(importFilter.getRootNode());
importMap(importFilter.getRootNode());
}
catch (IMapReader::FailureException& ex)
{
Expand Down
4 changes: 2 additions & 2 deletions radiantcore/map/algorithm/Import.h
Expand Up @@ -21,8 +21,8 @@ typedef std::shared_ptr<MapFormat> MapFormatPtr;
namespace algorithm
{

// Merges the map graph rooted at \p node into the global scene-graph.
void mergeMap(const scene::INodePtr& node);
// Integrates the map graph rooted at \p node into the global scene-graph.
void importMap(const scene::INodePtr& node);

/**
* Ensures that all names in the foreign root node are adjusted such that
Expand Down

0 comments on commit 1a5db5d

Please sign in to comment.