Skip to content

Commit

Permalink
Remove internal border in floating GroupDialog
Browse files Browse the repository at this point in the history
GroupDialog in the Floating layout had a 12 pixel border between the window
edge and the tabbed widget, which was just a waste of space.
  • Loading branch information
Matthew Mott committed Dec 19, 2020
1 parent 6e99daf commit 24f11b8
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
11 changes: 9 additions & 2 deletions radiant/ui/mainframe/FloatingLayout.h
Expand Up @@ -14,8 +14,15 @@ typedef std::shared_ptr<FloatingCamWnd> FloatingCamWndPtr;
class FloatingLayout;
typedef std::shared_ptr<FloatingLayout> FloatingLayoutPtr;

class FloatingLayout :
public IMainFrameLayout
/**
* \brief
* Original GIMP-style layout with multiple floating windows
*
* This layout is the most flexible, as it allows windows to be positioned and
* resized arbitrarily, but it is also more cumbersome to set up because the
* default window positions are not likely to be desirable.
*/
class FloatingLayout: public IMainFrameLayout
{
// The floating camera window
FloatingCamWndPtr _floatingCamWnd;
Expand Down
2 changes: 1 addition & 1 deletion radiant/uimanager/GroupDialog.cpp
Expand Up @@ -88,7 +88,7 @@ void GroupDialog::populateWindow()
panel->SetSizer(new wxBoxSizer(wxVERTICAL));

wxBoxSizer* vbox = new wxBoxSizer(wxVERTICAL);
panel->GetSizer()->Add(vbox, 1, wxEXPAND | wxALL, 12);
panel->GetSizer()->Add(vbox, 1, wxEXPAND);

_notebook = new wxNotebook(panel, wxID_ANY,
wxDefaultPosition, wxDefaultSize, wxNB_TOP, "GroupDialogNB");
Expand Down
14 changes: 6 additions & 8 deletions radiant/uimanager/GroupDialog.h
Expand Up @@ -12,6 +12,12 @@ class wxNotebook;
class wxBookCtrlEvent;
class wxImageList;

namespace ui
{

class GroupDialog;
typedef std::shared_ptr<GroupDialog> GroupDialogPtr;

/**
* greebo: The GroupDialog class creates the Window and the Notebook widget
* as soon as construct() is called.
Expand All @@ -24,18 +30,10 @@ class wxImageList;
* The name passed to the addPage() method can be used to directly toggle
* the notebook widgets via setPage(<name>).
*/

namespace ui
{

class GroupDialog;
typedef std::shared_ptr<GroupDialog> GroupDialogPtr;

class GroupDialog :
public wxutil::TransientWindow,
public IGroupDialog
{
private:
// Pages, sorted by position
typedef std::map<int, Page> Pages;

Expand Down

0 comments on commit 24f11b8

Please sign in to comment.