Skip to content

Commit

Permalink
Remove getFSGame/getFSGameBase methods from IGameManager interface.
Browse files Browse the repository at this point in the history
  • Loading branch information
codereader committed Dec 9, 2017
1 parent 69a835c commit 403fa66
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 36 deletions.
6 changes: 0 additions & 6 deletions include/igame.h
Expand Up @@ -67,12 +67,6 @@ class IGameManager :
// engine path is returned, e.g. /usr/local/doom3 or c:\games\doom3
virtual std::string getUserEnginePath() = 0;

// Returns the setting for fs_game
virtual const std::string& getFSGame() const = 0;

// Returns the setting for fs_game_base (can be empty)
virtual const std::string& getFSGameBase() const = 0;

/**
* greebo: Gets the mod path (e.g. ~/.doom3/gathers/).
* Returns the mod base path if the mod path itself is empty.
Expand Down
12 changes: 0 additions & 12 deletions plugins/script/interfaces/GameInterface.cpp
Expand Up @@ -31,16 +31,6 @@ std::string GameInterface::getModBasePath()
return GlobalGameManager().getModBasePath();
}

std::string GameInterface::getFSGame()
{
return GlobalGameManager().getFSGame();
}

std::string GameInterface::getFSGameBase()
{
return GlobalGameManager().getFSGameBase();
}

ScriptGame GameInterface::currentGame()
{
return ScriptGame(GlobalGameManager().currentGame());
Expand Down Expand Up @@ -70,8 +60,6 @@ void GameInterface::registerInterface(py::module& scope, py::dict& globals)
gameManager.def("getUserEnginePath", &GameInterface::getUserEnginePath);
gameManager.def("getModPath", &GameInterface::getModPath);
gameManager.def("getModBasePath", &GameInterface::getModBasePath);
gameManager.def("getFSGame", &GameInterface::getFSGame);
gameManager.def("getFSGameBase", &GameInterface::getFSGameBase);
gameManager.def("currentGame", &GameInterface::currentGame);
gameManager.def("getVFSSearchPaths", &GameInterface::getVFSSearchPaths);

Expand Down
2 changes: 0 additions & 2 deletions plugins/script/interfaces/GameInterface.h
Expand Up @@ -27,8 +27,6 @@ class GameInterface :
std::string getUserEnginePath();
std::string getModPath();
std::string getModBasePath();
std::string getFSGame();
std::string getFSGameBase();
ScriptGame currentGame();
PathList getVFSSearchPaths();

Expand Down
10 changes: 0 additions & 10 deletions radiant/settings/GameManager.cpp
Expand Up @@ -120,16 +120,6 @@ void Manager::initialiseModule(const ApplicationContext& ctx)
page.appendLabel(_("This page has been moved!\nPlease use the game settings dialog in the menu: File > Game/Project Setup..."));
}

const std::string& Manager::getFSGame() const
{
return GlobalRegistry().get(RKEY_FS_GAME);
}

const std::string& Manager::getFSGameBase() const
{
return GlobalRegistry().get(RKEY_FS_GAME_BASE);
}

const std::string& Manager::getModPath() const
{
// Return the fs_game path if available
Expand Down
6 changes: 0 additions & 6 deletions radiant/settings/GameManager.h
Expand Up @@ -54,12 +54,6 @@ class Manager :
*/
const std::string& getModBasePath() const override;

// greebo: Accessor method for the fs_game parameter
const std::string& getFSGame() const override;

// greebo: Accessor method for the fs_game_base parameter
const std::string& getFSGameBase() const override;

// greebo: Returns the current Game (shared_ptr).
IGamePtr currentGame() override;

Expand Down

0 comments on commit 403fa66

Please sign in to comment.