Skip to content

Commit

Permalink
Remove "initialiseModule called" console messages
Browse files Browse the repository at this point in the history
These messages aren't useful enough to be unconditionally baked into the
application, and if they become needed, they should be implemented in a
single location in the module system rather than with boilerplate lines
in every module.
  • Loading branch information
Matthew Mott committed Aug 3, 2022
1 parent b30c3c2 commit 691ce2c
Show file tree
Hide file tree
Showing 81 changed files with 0 additions and 143 deletions.
1 change: 0 additions & 1 deletion plugins/dm.conversation/plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class ConversationEditorModule :
}

virtual void initialiseModule(const IApplicationContext& ctx) {
rMessage() << getName() << "::initialiseModule called.\n";

// Add the callback event
GlobalCommandSystem().addCommand("ConversationEditor", ui::ConversationDialog::ShowDialog);
Expand Down
2 changes: 0 additions & 2 deletions plugins/dm.difficulty/plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ class DifficultyEditorModule :

void initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Add the callback event
GlobalCommandSystem().addCommand("DifficultyEditor", ui::DifficultyDialog::ShowDialog);

Expand Down
2 changes: 0 additions & 2 deletions plugins/dm.editing/plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ class EditingModule :

virtual void initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Associated "def_head" with an empty property editor instance
GlobalEntityInspector().registerPropertyEditor(
ui::DEF_HEAD_KEY, ui::AIHeadPropertyEditor::CreateNew);
Expand Down
2 changes: 0 additions & 2 deletions plugins/dm.gui/gui/GuiManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,6 @@ const StringSet& GuiManager::getDependencies() const

void GuiManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Search the VFS for GUIs
init();
}
Expand Down
2 changes: 0 additions & 2 deletions plugins/dm.gui/plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ class GuiModule :

void initialiseModule(const IApplicationContext& ctx) override
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalCommandSystem().addCommand("ReadableEditorDialog", ui::ReadableEditorDialog::RunDialog);
GlobalCommandSystem().addCommand("ReloadReadables", ui::ReadableReloader::run);

Expand Down
1 change: 0 additions & 1 deletion plugins/dm.objectives/objectives.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class ObjectivesEditorModule :
}

virtual void initialiseModule(const IApplicationContext& ctx) {
rMessage() << "ObjectivesEditorModule::initialiseModule called.\n";

// Add the callback event
GlobalCommandSystem().addCommand(
Expand Down
2 changes: 0 additions & 2 deletions plugins/dm.stimresponse/plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ class StimResponseModule :

void initialiseModule(const IApplicationContext& ctx) override
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Add the callback event
GlobalCommandSystem().addWithCheck("StimResponseEditor",
cmd::noArgs(ui::StimResponseEditor::ShowDialog),
Expand Down
2 changes: 0 additions & 2 deletions plugins/script/ScriptingSystem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,6 @@ const StringSet& ScriptingSystem::getDependencies() const

void ScriptingSystem::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Subscribe to get notified as soon as Radiant is fully initialised
module::GlobalModuleRegistry().signal_allModulesInitialised()
.connect(sigc::mem_fun(this, &ScriptingSystem::initialise));
Expand Down
2 changes: 0 additions & 2 deletions plugins/vcs/GitModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ const StringSet& GitModule::getDependencies() const

void GitModule::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Register commands
registerCommands();
createPreferencePage();
Expand Down
2 changes: 0 additions & 2 deletions radiant/camera/CameraWndManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,6 @@ const StringSet& CameraWndManager::getDependencies() const

void CameraWndManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// greebo: If at startup time the render mode is set to LIGHTING, fall back
// to textured. During startup the openGL contexts are not realised yet and the
// openGL module is tricked into believing there are no GLSL shader programs supported.
Expand Down
2 changes: 0 additions & 2 deletions radiant/clipboard/ClipboardModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ const StringSet& ClipboardModule::getDependencies() const

void ClipboardModule::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

wxTheApp->Bind(wxEVT_ACTIVATE_APP, &ClipboardModule::onAppActivated, this);
}

Expand Down
2 changes: 0 additions & 2 deletions radiant/eventmanager/EventManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ const StringSet& EventManager::getDependencies() const

void EventManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Deactivate the empty event, so it's safe to return it as NullEvent
_emptyEvent->setEnabled(false);

Expand Down
2 changes: 0 additions & 2 deletions radiant/map/StartupMapLoader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ const StringSet& StartupMapLoader::getDependencies() const

void StartupMapLoader::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalMainFrame().signal_MainFrameReady().connect(
sigc::mem_fun(*this, &StartupMapLoader::onMainFrameReady)
);
Expand Down
2 changes: 0 additions & 2 deletions radiant/settings/LocalisationModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ const StringSet& LocalisationModule::getDependencies() const

void LocalisationModule::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called" << std::endl;

// Construct the list of available languages
ComboBoxValueList langs;

Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/UserInterfaceModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ const StringSet& UserInterfaceModule::getDependencies() const

void UserInterfaceModule::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Output the wxWidgets version to the logfile
std::string wxVersion = string::to_string(wxMAJOR_VERSION) + ".";
wxVersion += string::to_string(wxMINOR_VERSION) + ".";
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/common/DialogManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ const StringSet& DialogManager::getDependencies() const

void DialogManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalMainFrame().signal_MainFrameShuttingDown().connect(
sigc::mem_fun(this, &DialogManager::clear));
}
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/favourites/FavouritesUserInterfaceModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ class FavouritesUserInterfaceModule :

void initialiseModule(const IApplicationContext& ctx) override
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalCommandSystem().addCommand("ToggleFavouritesBrowser",
sigc::mem_fun(this, &FavouritesUserInterfaceModule::togglePage));

Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/filters/FilterUserInterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ const StringSet& FilterUserInterface::getDependencies() const

void FilterUserInterface::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Create the Toggle objects to connect menu items and toggle buttons
refreshFilterToggles();

Expand Down
1 change: 0 additions & 1 deletion radiant/ui/gl/WxGLWidgetManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ const StringSet& WxGLWidgetManager::getDependencies() const

void WxGLWidgetManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;
}

void WxGLWidgetManager::shutdownModule()
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/grid/GridUserInterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ const StringSet& GridUserInterface::getDependencies() const

void GridUserInterface::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Add the grid status bar element
GlobalStatusBarManager().addTextElement("GridStatus", "grid_up.png",
statusbar::StandardPosition::GridSize, _("Current Grid Size"));
Expand Down
1 change: 0 additions & 1 deletion radiant/ui/groupdialog/GroupDialogManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const StringSet& GroupDialogManager::getDependencies() const

void GroupDialogManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called" << std::endl;
}

module::StaticModuleRegistration<GroupDialogManager> groupDialogManagerModule;
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/mainframe/MainFrame.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ const StringSet& MainFrame::getDependencies() const

void MainFrame::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << "MainFrame::initialiseModule called." << std::endl;

// Add another page for Multi-Monitor stuff
IPreferencePage& page = GlobalPreferenceSystem().getPage(_("Settings/Multi Monitor"));

Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/mainframe/MainFrameLayoutManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ const StringSet& MainFrameLayoutManager::getDependencies() const

void MainFrameLayoutManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << "MainFrameLayoutManager::initialiseModule called." << std::endl;

// Register the default layouts
registerLayout(EMBEDDED_LAYOUT_NAME, EmbeddedLayout::CreateInstance);
registerLayout(AUI_LAYOUT_NAME, AuiLayout::CreateInstance);
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/materials/editor/MaterialEditorModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ class MaterialEditorModule :

void initialiseModule(const IApplicationContext& ctx) override
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalCommandSystem().addCommand("MaterialEditor", MaterialEditor::ShowDialog, { cmd::ARGTYPE_STRING | cmd::ARGTYPE_OPTIONAL });

// Bind the command to the menu
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/mediabrowser/MediaBrowser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,6 @@ const StringSet& MediaBrowser::getDependencies() const

void MediaBrowser::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalCommandSystem().addCommand("ToggleMediaBrowser", sigc::mem_fun(this, &MediaBrowser::togglePage));

// We need to create the liststore and widgets before attaching ourselves
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/menu/MenuManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,6 @@ const StringSet& MenuManager::getDependencies() const

void MenuManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

loadFromRegistry();

GlobalMainFrame().signal_MainFrameShuttingDown().connect(
Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/statusbar/StatusBarManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ const StringSet& StatusBarManager::getDependencies() const

void StatusBarManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalMainFrame().signal_MainFrameShuttingDown().connect(
sigc::mem_fun(this, &StatusBarManager::onMainFrameShuttingDown));

Expand Down
2 changes: 0 additions & 2 deletions radiant/ui/texturebrowser/TextureBrowserManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ const StringSet& TextureBrowserManager::getDependencies() const

void TextureBrowserManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalEventManager().addRegistryToggle("TextureBrowserToggleUniformScale", RKEY_TEXTURE_USE_UNIFORM_SCALE);
GlobalEventManager().addRegistryToggle("TextureBrowserHideUnused", RKEY_TEXTURES_HIDE_UNUSED);
GlobalEventManager().addRegistryToggle("TextureBrowserShowFavouritesOnly", RKEY_TEXTURES_SHOW_FAVOURITES_ONLY);
Expand Down
2 changes: 0 additions & 2 deletions radiant/xyview/GlobalXYWnd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,6 @@ void XYWndManager::observeKey(const std::string& key)

void XYWndManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Connect self to the according registry keys
observeKey(RKEY_CHASE_MOUSE);
observeKey(RKEY_CHASE_MOUSE_CAP);
Expand Down
1 change: 0 additions & 1 deletion radiantcore/brush/BrushModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ const StringSet& BrushModuleImpl::getDependencies() const {
}

void BrushModuleImpl::initialiseModule(const IApplicationContext& ctx) {
rMessage() << "BrushModuleImpl::initialiseModule called." << std::endl;

construct();

Expand Down
2 changes: 0 additions & 2 deletions radiantcore/camera/CameraManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ const StringSet& CameraManager::getDependencies() const

void CameraManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalCommandSystem().addCommand("SetActiveCameraPosition",
std::bind(&CameraManager::setActiveCameraPosition, this, std::placeholders::_1), { cmd::ARGTYPE_VECTOR3 });
GlobalCommandSystem().addCommand("SetActiveCameraAngles",
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/clipper/Clipper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,6 @@ const StringSet& Clipper::getDependencies() const {

void Clipper::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << "Clipper::initialiseModule called\n";

_useCaulk = registry::getValue<bool>(RKEY_CLIPPER_USE_CAULK);
_caulkShader = GlobalRegistry().get(RKEY_CLIPPER_CAULK_SHADER);

Expand Down
2 changes: 0 additions & 2 deletions radiantcore/commandsystem/CommandSystem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ const StringSet& CommandSystem::getDependencies() const {

void CommandSystem::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << "CommandSystem::initialiseModule called." << std::endl;

// Add the built-in commands
addCommand("bind", std::bind(&CommandSystem::bindCmd, this, std::placeholders::_1), { ARGTYPE_STRING, ARGTYPE_STRING });
addCommand("unbind", std::bind(&CommandSystem::unbindCmd, this, std::placeholders::_1), { ARGTYPE_STRING });
Expand Down
1 change: 0 additions & 1 deletion radiantcore/eclass/EClassColourManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ const StringSet& EClassColourManager::getDependencies() const

void EClassColourManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;
}

module::StaticModuleRegistration<EClassColourManager> eclassColourManagerModule;
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/eclass/EClassManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ const StringSet& EClassManager::getDependencies() const

void EClassManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalFileSystem().addObserver(*this);

if (GlobalFileSystem().isInitialised())
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/entity/EntityModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,6 @@ const StringSet& Doom3EntityModule::getDependencies() const

void Doom3EntityModule::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

LightShader::m_defaultShader = game::current::getValue<std::string>("/defaults/lightShader");

GlobalCommandSystem().addCommand("CreateSpeaker", std::bind(&algorithm::CreateSpeaker, std::placeholders::_1),
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/filetypes/FileTypeRegistry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ const StringSet& FileTypeRegistry::getDependencies() const

void FileTypeRegistry::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

registerPattern("*", FileTypePattern(_("All Files"), "*", "*.*"));
}

Expand Down
2 changes: 0 additions & 2 deletions radiantcore/fonts/FontManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ const StringSet& FontManager::getDependencies() const

void FontManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called" << std::endl;

_loader = std::make_unique<FontLoader>(*this);

// Find installed fonts in a new thread
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/grid/GridManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ const StringSet& GridManager::getDependencies() const

void GridManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << "GridManager::initialiseModule called.\n";

populateGridItems();
registerCommands();

Expand Down
2 changes: 0 additions & 2 deletions radiantcore/layers/LayerModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ class LayerModule :

void initialiseModule(const IApplicationContext& ctx) override
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

GlobalCommandSystem().addCommand(COMMAND_ADDTOLAYER,
std::bind(&LayerModule::addSelectionToLayer, this, std::placeholders::_1),
{ cmd::ARGTYPE_INT });
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/map/EditingStopwatch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ const StringSet& EditingStopwatch::getDependencies() const

void EditingStopwatch::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

_mapSignal = GlobalMapModule().signal_mapEvent().connect(
sigc::mem_fun(*this, &EditingStopwatch::onMapEvent)
);
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/map/Map.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1486,8 +1486,6 @@ const StringSet& Map::getDependencies() const

void Map::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

// Register for the startup event
_mapPositionManager.reset(new MapPositionManager);

Expand Down
1 change: 0 additions & 1 deletion radiantcore/map/MapResourceManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const StringSet& MapResourceManager::getDependencies() const

void MapResourceManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;
}

// Define the MapResourceManager registerable module
Expand Down
2 changes: 0 additions & 2 deletions radiantcore/map/RegionManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,6 @@ const StringSet& RegionManager::getDependencies() const

void RegionManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;

initialiseCommands();

_worldMin = game::current::getValue<float>("/defaults/minWorldCoord");
Expand Down
1 change: 0 additions & 1 deletion radiantcore/map/aas/AasFileManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ const StringSet& AasFileManager::getDependencies() const

void AasFileManager::initialiseModule(const IApplicationContext& ctx)
{
rMessage() << getName() << "::initialiseModule called." << std::endl;
}

// Define the static AasFileManager module
Expand Down

0 comments on commit 691ce2c

Please sign in to comment.