#5374: Fix crash in Map::exportSelected due to a beginner's fault, pa…

…ssing a reference to an instance that is about to be deleted as soon as the call returns.
codereader · Nov 1, 2020 · a729e93 · a729e93
1 parent 4d1d5d2
commit a729e93
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/radiantcore/map/Map.cpp b/radiantcore/map/Map.cpp
@@ -814,7 +814,8 @@ void Map::exportSelected(std::ostream& out, const MapFormatPtr& format)
     assert(format);
 
     // Create our main MapExporter walker for traversal
-    MapExporter exporter(*format->getMapWriter(), GlobalSceneGraph().root(), out);
+    auto writer = format->getMapWriter();
+    MapExporter exporter(*writer, GlobalSceneGraph().root(), out);
 
     // Pass the traverseSelected function and start writing selected nodes
     exporter.exportMap(GlobalSceneGraph().root(), scene::traverseSelected);