#5532: The value of the polygonOffset keyword is optional, adjust the…

… parser
codereader · Feb 19, 2021 · a7352a9 · a7352a9
1 parent 110bc03
commit a7352a9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/include/ishaders.h b/include/ishaders.h
@@ -58,6 +58,7 @@ class Material
 		FLAG_NOPORTALFOG			= 1 << 8,		// noPortalFog
 		FLAG_UNSMOOTHEDTANGENTS		= 1 << 9,		// unsmoothedTangents
 		FLAG_MIRROR					= 1 << 10,		// mirror
+		FLAG_POLYGONOFFSET			= 1 << 11,		// has polygonOffset
 	};
 
 	// Surface Flags

diff --git a/radiantcore/shaders/ShaderTemplate.cpp b/radiantcore/shaders/ShaderTemplate.cpp
@@ -94,7 +94,26 @@ bool ShaderTemplate::parseShaderFlags(parser::DefTokeniser& tokeniser,
     }
 	else if (token == "polygonoffset")
 	{
-		_polygonOffset = string::convert<float>(tokeniser.nextToken(), 0);
+        _materialFlags |= Material::FLAG_POLYGONOFFSET;
+
+        // The value argument is optional, try to parse the next token
+        if (tokeniser.hasMoreTokens())
+        {
+            try
+            {
+                _polygonOffset = std::stof(tokeniser.peek());
+                // success, exhaust the token
+                tokeniser.skipTokens(1);
+            }
+            catch (const std::logic_error&) // logic_error is base of invalid_argument out_of_range exceptions
+            {
+                _polygonOffset = 1.0f;
+            }
+        }
+        else
+        {
+            _polygonOffset = 1.0f;
+        }
 	}
 	else if (token == "clamp")
 	{