Skip to content

Commit

Permalink
Fix GroupDialog tabs behaviour in OSX.
Browse files Browse the repository at this point in the history
  • Loading branch information
codereader committed Feb 19, 2017
1 parent 70379ec commit bae1027
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions plugins/uimanager/GroupDialog.cpp
Expand Up @@ -281,9 +281,6 @@ wxWindow* GroupDialog::addPage(const PagePtr& page)
page->page->Reparent(_notebook.get());
_notebook->InsertPage(insertPosition, page->page, page->tabLabel, false, imageId);

// Call Show() on the tab content again, otherwise it ends up invisible in OSX
page->page->Show();

// Add this page by copy to the local list
_pages.insert(std::make_pair(page->position, Page(*page)));

Expand Down Expand Up @@ -318,6 +315,9 @@ void GroupDialog::updatePageTitle(int pageNumber)
void GroupDialog::onPageSwitch(wxBookCtrlEvent& ev)
{
updatePageTitle(ev.GetSelection());

// Be sure to skip the event, otherwise pages stay hidden
ev.Skip();
}

} // namespace ui

0 comments on commit bae1027

Please sign in to comment.