#5231: Console window (again) shows output from before it was attache…

…d to the LogWriter

include/ilogwriter.h

@@ -37,6 +37,17 @@ class ILogDevice
 	 * a log string as argument.
 	 */
 	virtual void writeLog(const std::string& outputStr, LogLevel level) = 0;
+
+	/**
+	 * If this device is a console, it will be filled with the log output
+	 * that has been collected before it has been attached.
+	 * This is supposed to make it easier to inspect the startup phase opening
+	 * the console viewer in the UI.
+	 */
+	virtual bool isConsole() const 
+	{
+		return false;
+	}
 };
 
 /**

radiant/log/Console.h

@@ -56,6 +56,11 @@ class Console :
 	 * (Note: this gets called by the LogWriter automatically).
 	 */
 	void writeLog(const std::string& outputStr, applog::LogLevel level) override;
+
+	bool isConsole() const override
+	{
+		return true; // Receive the buffered log output when attached
+	}
 };
 
 } // namespace ui

radiant/log/LogWriter.cpp

@@ -40,14 +40,11 @@ std::mutex& LogWriter::getStreamLock()
 
 void LogWriter::attach(ILogDevice* device)
 {
-	bool firstDevice = _devices.empty();
-
 	_devices.insert(device);
 
-	if (firstDevice)
+	if (device->isConsole())
 	{
-		// The first device has the honour to receive all the buffered output
-		// Copy the temporary buffers over
+		// The first console device receives all the buffered output
 		if (applog::StringLogDevice::InstancePtr())
 		{
 			applog::StringLogDevice& logger = *applog::StringLogDevice::InstancePtr();
@@ -62,7 +59,6 @@ void LogWriter::attach(ILogDevice* device)
 			}
 		}
 
-		// Destruct the temporary buffer
 		applog::StringLogDevice::destroy();
 	}
 }