#5893: Don't attach empty model surfaces, the GeometryRenderer doesn'…

…t support this
codereader · Feb 4, 2022 · c028385 · c028385
1 parent eacb2ea
commit c028385
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/radiantcore/model/StaticModelNode.cpp b/radiantcore/model/StaticModelNode.cpp
@@ -30,6 +30,11 @@ void StaticModelNode::onInsertIntoScene(scene::IMapRootNode& root)
     // Renderables will acquire their shaders in onPreRender
     _model->foreachSurface([&](const StaticModelSurface& surface)
     {
+        if (surface.getVertexArray().empty() || surface.getIndexArray().empty())
+        {
+            return; // don't handle empty surfaces
+        }
+
         _renderableSurfaces.emplace_back(std::make_shared<RenderableModelSurface>(surface, localToWorld()));
     });
 

diff --git a/radiantcore/model/md5/MD5ModelNode.cpp b/radiantcore/model/md5/MD5ModelNode.cpp
@@ -76,6 +76,11 @@ void MD5ModelNode::onInsertIntoScene(scene::IMapRootNode& root)
     // Renderables will acquire their shaders in onPreRender
     _model->foreachSurface([&](const MD5Surface& surface)
     {
+        if (surface.getVertexArray().empty() || surface.getIndexArray().empty())
+        {
+            return; // don't handle empty surfaces
+        }
+
         _renderableSurfaces.emplace_back(
             std::make_shared<model::RenderableModelSurface>(surface, localToWorld())
         );