De-duplicate replace_all and replace_all_copy

Avoid a duplicated function body by having replace_all_copy simply call
replace_all on a local copy of the string and then return it.

libs/string/replace.h

@@ -5,7 +5,7 @@
 namespace string
 {
 
-/** 
+/**
  * Replaces all occurrences of the given search string in the subject
  * with the given replacement, in-place.
  */
@@ -23,24 +23,15 @@ inline void replace_all(std::string& subject, const std::string& search, const s
 }
 
 /**
- * Replaces all occurrences of of the given search string with 
- * the given replacement and returns a new string instance 
+ * Replaces all occurrences of of the given search string with
+ * the given replacement and returns a new string instance
  * containing the result. The incoming subject is passed by value such
  * that the original string is not altered.
  */
 inline std::string replace_all_copy(std::string subject, const std::string& search, const std::string& replacement)
 {
-	if (search.empty()) return subject; // nothing to do
-
-	std::size_t pos = 0;
-
-	while ((pos = subject.find(search, pos)) != std::string::npos)
-	{
-		subject.replace(pos, search.length(), replacement);
-		pos += replacement.length();
-	}
-
-	return subject;
+    replace_all(subject, search, replacement);
+    return subject;
 }
 
 /**
@@ -52,7 +43,7 @@ inline void replace_first(std::string& subject, const std::string& search, const
 	if (search.empty()) return; // nothing to do
 
 	std::size_t pos = subject.find(search);
-	
+
 	if (pos != std::string::npos)
 	{
 		subject.replace(pos, search.length(), replacement);