#5584: TargetLineNode cleanup

codereader · Dec 4, 2021 · e96f65c · e96f65c
1 parent ee5d717
commit e96f65c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/radiantcore/entity/target/TargetLineNode.cpp b/radiantcore/entity/target/TargetLineNode.cpp
@@ -25,6 +25,7 @@ scene::INode::Type TargetLineNode::getNodeType() const
 
 const AABB& TargetLineNode::localAABB() const
 {
+    static AABB _aabb;
     return _aabb;
 }
 
@@ -57,19 +58,10 @@ void TargetLineNode::onPreRender(const VolumeTest& volume)
 
 void TargetLineNode::renderSolid(IRenderableCollector& collector, const VolumeTest& volume) const
 {
-#if 0
-    renderWireframe(collector, volume);
-#endif
 }
 
 void TargetLineNode::renderWireframe(IRenderableCollector& collector, const VolumeTest& volume) const
 {
-#if 0
-    // If the owner is hidden, the lines are hidden too
-    if (!_targetLines.hasTargets() || !_owner.visible()) return;
-
-	_targetLines.render(_owner.getWireShader(), collector, volume, getOwnerPosition());
-#endif
 }
 
 void TargetLineNode::renderHighlights(IRenderableCollector& collector, const VolumeTest& volume)

diff --git a/radiantcore/entity/target/TargetLineNode.h b/radiantcore/entity/target/TargetLineNode.h
@@ -20,11 +20,9 @@ class TargetLineNode final :
     public scene::Node
 {
 private:
-    AABB _aabb;
-
     EntityNode& _owner;
 
-    mutable RenderableTargetLines _targetLines;
+    RenderableTargetLines _targetLines;
 
 public:
     TargetLineNode(EntityNode& owner);