Work around an issue with dynamic_casts failing when downcasting to t…

…he intermediate Base class scene::Node, originating from code located in a static library.
codereader · Feb 19, 2017 · f550887 · f550887
1 parent 3a55493
commit f550887
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/include/inode.h b/include/inode.h
@@ -241,6 +241,9 @@ class INode :
 	// not by the UndoSystem itself, at least not yet.
 	virtual void onPostUndo() {}
 	virtual void onPostRedo() {}
+
+    // Called during recursive transform changed, but only by INodes themselves
+    virtual void transformChangedLocal() = 0;
 };
 
 } // namespace scene
diff --git a/libs/scene/Node.cpp b/libs/scene/Node.cpp
@@ -459,9 +459,9 @@ void Node::transformChanged()
 	transformChangedLocal();
 
 	// Next, traverse the children and notify them
-	_children.foreachNode([] (const scene::INodePtr& child)->bool
+	_children.foreachNode([this] (const scene::INodePtr& child)->bool
 	{
-		std::dynamic_pointer_cast<Node>(child)->transformChangedLocal();
+		child->transformChangedLocal();
 		return true;
 	});
 

diff --git a/libs/scene/Node.h b/libs/scene/Node.h
@@ -148,7 +148,7 @@ class Node :
 
 	const Matrix4& localToWorld() const;
 
-	void transformChangedLocal();
+	void transformChangedLocal() override;
 
 	void transformChanged();