Skip to content

Commit

Permalink
#6097: Remove the dangerous copy-constructor which will trigger a cra…
Browse files Browse the repository at this point in the history
…sh as soon as the second copy goes out of scope.
  • Loading branch information
codereader committed Sep 11, 2022
1 parent 2792343 commit ffb7602
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
4 changes: 0 additions & 4 deletions libs/xmlutil/Document.cpp
Expand Up @@ -64,10 +64,6 @@ Document::Document(std::istream& stream) :
xmlFreeParserCtxt(ctxt);
}

Document::Document(const Document& other) :
_xmlDoc(other._xmlDoc)
{}

Document::~Document()
{
if (_xmlDoc != nullptr)
Expand Down
3 changes: 0 additions & 3 deletions libs/xmlutil/Document.h
Expand Up @@ -41,9 +41,6 @@ class Document
// stream data into memory, and parse it chunk by chunk.
Document(std::istream& stream);

// Copy constructor (note: does not create an actual copy of the internal xmlDoc)
Document(const Document& other);

// Destructor, frees the xmlDocPtr
~Document();

Expand Down

0 comments on commit ffb7602

Please sign in to comment.