Multidimensional encoding #622
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase this with master? |
cskiraly
force-pushed
the
encoding-multidim
branch
from
696f7b1
to
3b30794
Compare
We can protect in multiple dimensions, which require the manifest to describe all dimensions, either directly, or by making the structure recursive. Here we make it recursive. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
there was a different CID for something declared an empty block (used for padding), and the block with all 0s. This becomes a problem after decode, where the docoder returns a block with all 0s. This is a workaround, not a real solution. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
cskiraly
force-pushed
the
encoding-multidim
branch
from
3b30794
to
cc3ae92
Compare
|
rebased on master now |
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
This reverts commit 05933c6.
Since repostore is not reference counting, and a single parity is often the same as one of the blocks, test easily delete more blocks than intended. Better to use M=2 Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds multidimensional encoding capabilities to the manifest.
In this patch set
The concept of recursive manifest is questionable. It might be better to support multiple K,M parameters in a single manifest, describing the whole multi-d RS encoding structure without recursion. This would allow to handle originalBlockCount and padding blocks better.
It should be relatively easy to convert this implementation to a non-recursive version. ID mapping changes, but operations are the same, and encoding is done dimension-by-dimension anyway.