Pr add prover benchmark tool #790
Merged
+418
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
reviewed
May 16, 2024
dryajov
reviewed
May 16, 2024
dryajov
reviewed
May 16, 2024
benchmarks/utils.nim
Outdated
| for v in vals: | ||
| elapsedStr &= ", " & v.formatFloat(format = ffDecimal, precision = 3) | ||
| stdout.styledWriteLine( | ||
| fgGreen, "CPU Time [", benchmarkName, "] ", "avg(", $nn, "): ", elapsedStr, " s" |
There was a problem hiding this comment.
Can we actually derive an average for the number of runs here? in fact, I would print this on it's own line at the end of the bench run.
Something like:
"CPU Time ["... "], ...s"
...
"Average for ${nn} runs is ...."There was a problem hiding this comment.
Definitely, I was thinking about doing that. The current form is because I wanted to print out each run so I could do a simple linear regression on it. It's a pain to work with though in this form.
dryajov
previously approved these changes
May 22, 2024
dryajov
reviewed
May 23, 2024
cleanup wording Signed-off-by: Dmitriy Ryajov <dryajov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.