Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone 5 compatibilty #10

Merged
merged 10 commits into from Aug 20, 2015
Merged

Plone 5 compatibilty #10

merged 10 commits into from Aug 20, 2015

Conversation

tomgross
Copy link
Member

Make compatible with Plone 5
Port tests to plone.app.testing
Use custom testing portlet to be independent from Plone changes for testing
added buildouts for Plone 4.3 and Plone 5

tomgross added a commit that referenced this pull request Aug 20, 2015
@tomgross tomgross merged commit 8f2f142 into master Aug 20, 2015
@keul
Copy link
Member

keul commented Aug 20, 2015

@tomgross great!

I'm not only convinced about 2 changes here:

  • setup.py version is 1.2.3.dev0. This will trigger the zest.releaser syndrome where every new release seems a bugfix release just because releaser will click "enter". You added lot of new features and dropped Plone 3 compatibility. I think 1.3.0.dev0 will be better.
  • metadata.xml to 1003: same as above. 1100 is IMO better. Using 1003 wil make impossibile for anybody to release a new Plone 1.2.x version

@tomgross
Copy link
Member Author

Thanks for your feedback @keul !
I updated master with your suggestions

@tomgross tomgross deleted the tomgross-plone5 branch August 20, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants