Prevent invalid data to be silently accepted #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforcada
force-pushed
the
invalid-data-is-silently-accepted
branch
2 times, most recently
from
d57af6c
to
75096ad
Compare
When a user wants sets a ``Date`` or ``Datetime`` value and misses one of the fields (day, year, hour or minute) it is silently set to None without any 'input is not valid' error message being displayed. Unfortunately it can not be checked on a validator because the input value has already been converted to a ``datetime``. This commit works around it making sure an error is raised and only convert it to None if both *day* and *year* are left empty.
gforcada
force-pushed
the
invalid-data-is-silently-accepted
branch
from
75096ad
to
b0a9533
Compare
gforcada
changed the title
gforcada
added a commit
that referenced
this pull request
Oct 21, 2015
Prevent invalid data to be silently accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user wants sets a
DateorDatetimevalue and missesone of the fields (day, year, hour or minute) it is silently set to
None without any 'input is not valid' error message being displayed.
Unfortunately it can not be checked on a validator because the input
value has already been converted to a
datetime.This commit works around it making sure an error is raised and only
convert it to None if both day and year are left empty.