Implement new deserializer for datetime fields. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def __call__(self, value, filestore, item, | ||
| disable_constraints=False, logger=None): | ||
| if isinstance(value, basestring): | ||
| value = datetime.strptime(value, '%Y-%m-%d %H:%M:%S') |
There was a problem hiding this comment.
For example with collective.jsonify, we might have differently formatted dates, e.g. 2004/12/30 00:20:00 GMT+1.
I propose to let zope's DateTime handle everything and to not define a format:
>>> from DateTime import DateTime
>>> DateTime('2015-12-31 17:59:59').asdatetime()
datetime.datetime(2015, 12, 31, 17, 59, 59)
>>> DateTime("2004/12/30 00:20:00 GMT+1").asdatetime()
datetime.datetime(2004, 12, 30, 0, 20, tzinfo=<StaticTzInfo 'GMT+1'>)alternatively we'd have to make the format configurable 😕
There was a problem hiding this comment.
Good idea 👍 I have made the needed modifications.
mbaechtold
force-pushed
the
add-datetime-deserializer
branch
from
6142e6a
to
b7c6d89
Compare
|
👍 |
mbaechtold
force-pushed
the
add-datetime-deserializer
branch
from
b7c6d89
to
648d421
Compare
jone
added a commit
that referenced
this pull request
Aug 28, 2015
Implement new deserializer for datetime fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.