CLYS-116 - Unity example patches #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchLucid
reviewed
Aug 26, 2022
| @@ -84,6 +83,7 @@ private void InitializeInstance() | |||
| } | |||
|
|
|||
| Instance = GetComponent<T>(); | |||
| _colyseusSettings = ScriptableObject.CreateInstance<ColyseusSettings>(); | |||
There was a problem hiding this comment.
Originally the settings object was designed to be able to be assigned in editor so devs could have multiple settings objects (local, dev, staging, prod, etc). @lpsandaruwan can you confirm that this doesn't break that functionality? Or if it does/needs to thats ok too, we just need to be able to provide an explanation/workaround for people who use that feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settingsfor ColyseusSettings in example