Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error checking on build. #163

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

airportyh
Copy link

This implements syntax error checking on build: componentjs/component#478 - based on tag 0.10.0.

Here are benchmarks which show that this change has negligible performance impact:

https://gist.github.com/airportyh/9014213

@jonathanong
Copy link
Contributor

ohh got it. only things i can think of off the bat is 1) style and 2) make sure you're reading a .js file for robustness since some people like to put their coffee in scripts (though i'm not exactly sure how it'll work right now if someone has coffee files in scripts without using a coffee plugin. just want to make sure it doesn't crash).

@airportyh
Copy link
Author

@jonathanong please check new commits to address #1 and #2. I had no idea component supports CoffeeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants